Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internet personal account #1744

Closed
wants to merge 7 commits into from
Closed

Internet personal account #1744

wants to merge 7 commits into from

Conversation

AmrAdelKhalil
Copy link
Contributor

fixes #1671

vbrazo
vbrazo requested changes Sep 14, 2019
View reviewed changes
lib/faker/default/internet.rb Outdated Show resolved Hide resolved
@AmrAdelKhalil AmrAdelKhalil mentioned this pull request Sep 15, 2019
Closed
@bpleslie
Copy link
Member

I think we should close this in favor of #1730. Also suggested by the author in #1671. 👍

@bpleslie bpleslie closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

@vbrazo vbrazo vbrazo requested changes

Assignees

@AmrAdelKhalil AmrAdelKhalil

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add User generator that accepts arguments
4 participants
@AmrAdelKhalil @bpleslie @olleolleolle @vbrazo