Add races and class names to WorldOfWarcraft #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathisto
changed the title
Zeragamba
suggested changes
Jun 11, 2020
mathisto
force-pushed
the
improve-world-of-warcraft
branch
from
5443aa5 to
1b0cf26
Compare
Zeragamba
suggested changes
Sep 28, 2020
Zeragamba
approved these changes
Sep 28, 2020
|
Thanks! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Pluralize heroes in yml. Add class_names * Add races * Remove 'the' from documentation. * Use version next for generators * Reformat yml with one entry per line * Revert version numbers on existing generators * Fix version number on generator
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit aaa3692.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit aaa3692.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
Adds two additional methods and associated content to the WorldOfWarcraft class,
raceandclass_name. All data was pulled directly from the Wowpedia