Add yard docs for Faker::Coffee methods #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorshea
requested changes
Oct 19, 2019
lib/faker/default/coffee.rb
Outdated
| # @example | ||
| # Faker::Coffee.blend_name #=> "Major Java" | ||
| # | ||
| # @faker.version next |
There was a problem hiding this comment.
The methods for Faker::Coffee were added in 1.8.0, except for intensifier which was added in 1.9.0. All of these should be changed to reflect that.
bpleslie
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Looks good other than @connorshea comment. Thanks for the contribution!
|
@LuanGB welcome! |
Closed
sanikkenway
added a commit
to sanikkenway/faker
that referenced
this pull request
Nov 12, 2019
Add yard docs for Faker::Coffee methods (faker-ruby#1810)
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Add yard docs for Faker::Coffee methods * @faker.version should be 1.9.0
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add yard docs for Faker::Coffee methods * @faker.version should be 1.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add yard docs for Faker::Coffee methods