Add YARD docs for Faker::Music{,::Opera} #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| # @return [Array<String>] | ||
| # | ||
| # @faker.version 1.6.4 | ||
| def keys | ||
| %w[C D E F G A B] |
There was a problem hiding this comment.
I know it's not related to your Pull Request, I'm just commenting so we can discuss it :)
Maybe this should become an array inside the localization file or perhaps a constant? (I'd prefer the latter since it probably won't ever change?)
There was a problem hiding this comment.
Seems reasonable to me, I'll push another commit to this PR
There was a problem hiding this comment.
Oops, seems it's already been merged 🤷♂ @lucasqueiroz want me to open another?
There was a problem hiding this comment.
Yes, you can open a new PR please. Thanks for contributing @jas14
lucasqueiroz
approved these changes
Dec 23, 2019
vbrazo
approved these changes
Dec 23, 2019
Closed
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Add Faker::Music YARD docs * Add Faker::MUsic::Opera YARD docs
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add Faker::Music YARD docs * Add Faker::MUsic::Opera YARD docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1762
Description:
Adds YARD docs for
Faker::MusicandFaker::Music::Opera.