Add Faker::Music#mambo_no_5, a Generator for Random First Names that Appear in Lou Bega's Mambo No. 5 #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickyEXE
changed the title
NickyEXE
changed the title
NickyEXE
requested review from
Zeragamba and
vbrazo
and removed request for
Zeragamba
Zeragamba
reviewed
Feb 6, 2020
|
I think if this was moved to |
psibi
reviewed
May 29, 2020
psibi
requested changes
May 29, 2020
There was a problem hiding this comment.
LGTM apart from a single comment (and @Zeragamba other comments which needs to be addressed)
NickyEXE
changed the title
|
I made several changes to the pull request to address notes here. Per Zeragamba's note:
I instead made #mambo_no_5 a method on Faker::Music (I worried mambo may be too ambiguous of a method name). I think the new pull request captures all the notes. Appreciate the reviews. |
psibi
reviewed
Apr 10, 2021
psibi
reviewed
Apr 10, 2021
Co-authored-by: Sibi Prabakaran <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-StoryDescription:
This is a unique faker generator for generating first names, where all first names are names mentioned in Lou Bega's 1999 song "Mambo No. 5 (A Little Bit of...)".
It will be used largely for seeding data for first names for test applications.
I'm a coach at a coding bootcamp and always am looking for new weird faker modules to use for seeding data when demonstrating ideas to students. While there are a lot of fun ones that see a lot of use, there are relatively few for first names that don't have to do with TV shows (there are only so many labs you can do where everyone's named Danaerys). For fun and out of appreciation for Lou Bega, I made this PR.