Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EOL Rubies from CI tests #2038

Merged
merged 5 commits into from
Jun 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ jobs:
fail-fast: false # don't fail all matrix builds if one fails
matrix:
ruby:
- '2.3'
- '2.4'
- '2.5'
- '2.6'
- '2.7'
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AllCops:
TargetRubyVersion: 2.3
TargetRubyVersion: 2.5

Layout/LineLength:
Description: This cop checks the length of lines in the source code. The maximum length is configurable.
Expand Down
2 changes: 1 addition & 1 deletion faker.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.bindir = 'bin'
spec.executables = ['faker']
spec.require_paths = ['lib']
spec.required_ruby_version = '>= 2.3'
spec.required_ruby_version = '>= 2.5'

spec.metadata['changelog_uri'] = 'https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md'
spec.metadata['source_code_uri'] = 'https://github.com/faker-ruby/faker'
Expand Down
2 changes: 1 addition & 1 deletion lib/helpers/base58.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def self.encode(str)
base = alphabet.size

lv = 0
str.split('').reverse.each_with_index { |v, i| lv += v.unpack('C')[0] * 256**i }
str.split('').reverse.each_with_index { |v, i| lv += v.unpack('C') * 256**i }

ret = +''
while lv.positive?
Expand Down
8 changes: 3 additions & 5 deletions test/faker/default/test_country_code.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@ def test_country_code_long_expected_length
def test_all_country_code_have_country
codes = Faker::Base.fetch_all('address.country_code')
lonely_codes = codes.reject do |code|
begin
Faker::Address.country_by_code(code: code)
rescue I18n::MissingTranslationData
nil
end
Faker::Address.country_by_code(code: code)
rescue I18n::MissingTranslationData
nil
end

assert_equal([], lonely_codes)
Expand Down