Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove country code from phone numbers #2087

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix/remove country code from phone numbers #2087

merged 2 commits into from
Jul 27, 2020

Conversation

gabrielbaldao
Copy link
Contributor

#2085

I am not sure about some countries, I would like a good review

@gabrielbaldao gabrielbaldao changed the title Fix/remove country code from phone numbers WIP: Fix/remove country code from phone numbers Jul 22, 2020
@gabrielbaldao gabrielbaldao force-pushed the fix/remove-country-code-from-phone-numbers branch from d44f8b0 to a373f1d Compare July 22, 2020 13:10
@gabrielbaldao gabrielbaldao changed the title WIP: Fix/remove country code from phone numbers Fix/remove country code from phone numbers Jul 22, 2020
@gabrielbaldao gabrielbaldao force-pushed the fix/remove-country-code-from-phone-numbers branch 3 times, most recently from 502155f to 6b9a99c Compare July 22, 2020 13:50
psibi
psibi reviewed Jul 23, 2020
View reviewed changes
lib/locales/de-CH.yml Outdated Show resolved Hide resolved
psibi
psibi requested changes Jul 23, 2020
View reviewed changes
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. But I think it still requires some minor changes.

@psibi
Copy link
Member

psibi commented Jul 25, 2020

@gabrielbaldao Do you think you will be able to update the PR with the remaining fixes ? Thanks!

@gabrielbaldao
Copy link
Contributor Author

@gabrielbaldao Do you think you will be able to update the PR with the remaining fixes ? Thanks!

Sure, I will fix this comments today,

@gabrielbaldao gabrielbaldao force-pushed the fix/remove-country-code-from-phone-numbers branch from 6b9a99c to 57a284d Compare July 26, 2020 18:12
@gabrielbaldao gabrielbaldao requested a review from psibi July 26, 2020 18:12
@psibi psibi merged commit 13fce80 into faker-ruby:master Jul 27, 2020
@psibi
Copy link
Member

psibi commented Jul 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudeeptarlekar sudeeptarlekar sudeeptarlekar left review comments

@psibi psibi psibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielbaldao @psibi @sudeeptarlekar