Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2097 Added barcodes #2104

Merged
merged 4 commits into from
Aug 13, 2020
Merged

2097 Added barcodes #2104

merged 4 commits into from
Aug 13, 2020

Conversation

sudeeptarlekar
Copy link
Contributor

Issue#

resolves #2097

Description:

Added EAN-8, EAN-13, UPC_A, UPC_E, ISBN, ISMN, ISSN barcodes

@sudeeptarlekar sudeeptarlekar marked this pull request as draft August 7, 2020 12:04
Zeragamba
Zeragamba approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are required, especially with code that's a bit more complex then just serving values from the locales.

lib/faker/default/barcode.rb Outdated Show resolved Hide resolved
Zeragamba
Zeragamba suggested changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tapped the approved radio button accidentally.

@sudeeptarlekar sudeeptarlekar marked this pull request as ready for review August 7, 2020 16:39
@sudeeptarlekar
Copy link
Contributor Author

@Zeragamba added tests for barcode, can I get a review?

@sudeeptarlekar sudeeptarlekar changed the title Added barcodes 2097 Added barcodes Aug 10, 2020
Zeragamba
Zeragamba approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Zeragamba Zeragamba merged commit 81c3d9d into faker-ruby:master Aug 13, 2020
@Zeragamba
Copy link
Contributor

Thanks!

@sudeeptarlekar sudeeptarlekar deleted the 2097-faker-barcodes branch December 1, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A barcode generator
2 participants
@sudeeptarlekar @Zeragamba