Faker adjectives

[loicboset]

Description:

This is a PR to add a new faker generator for adjectives.
A few weeks ago I had to create an Airbnb clone and I wanted to use Faker to generate flats description ("Nice apartment", "Cosy studio", ...) but I did not find any suitable Faker.

Hence this generator, which includes 'nice' adjectives ('clean', 'charming') and 'bad' adjectives ('horrible', 'lazy') that can be used for multiple purposes.

This is my first real PR request 🙏

I added the 4 files you will see, including the test (which passes).

However, even though I did not touch the Bank Faker, I get an error on this one after having added my changes (I ran the test before adding my changes and all tests pass, so it has to do with my changes).

/Users/loic/Desktop/Playground/faker/test/faker/default/test_faker_bank.rb:51:in `times'
     51:     10.times do
     52:       samplebic1 = @tester.swift_bic
     53:       samplebic2 = @tester.swift_bic
  => 54:       refute_equal samplebic1, samplebic2
     55:     end
     56:   end
     57: 
/Users/loic/Desktop/Playground/faker/test/faker/default/test_faker_bank.rb:54:in `block in test_swift_bic_collission'
Failure: test_swift_bic_collission(TestFakerBank):
  <"AAHVGB21"> was expected to be != to
  <"AAHVGB21">.

Obviously, I missed something so if you have any clue what to change to make all tests pass, please let me know! 💪

[psibi]

@loicboset Can you see why most of the tests are failing ?

[loicboset]

@psibi yes, for a reason that I don't understand the bank faker is failing although I have not touched it.

Failure: test_swift_bic_collission(TestFakerBank):
  <"AAHVGB21"> was expected to be != to
  <"AAHVGB21">.

Do you have an idea why?

[psibi]

@sudeeptarlekar / @Zeragamba Do you know what's going wrong in the tests ?

[Zeragamba]

Adjective could be a reserved class name for something?

[loicboset]

I changed all the names to Adjectivees (adding one e and one s) but the same test is failing. I will try this weekend to create a different faker to check if I get the same result.

[psibi]

@loicboset I looked into this in more detail today and IMO the test is wrong:

  # This test makes sure there are no collissions in BIC number pool
  def test_swift_bic_collission
    10.times do
      samplebic1 = @tester.swift_bic
      samplebic2 = @tester.swift_bic
      refute_equal samplebic1, samplebic2
    end
  end

Faker doesn't guarantee that the value will be unique always: https://github.com/faker-ruby/faker#note

So, IMO that test is wrong. Free feel to comment the test out. I don't want this MR to get stagnated because of the test.

[loicboset]

@psibi thanks! Everything seems good now!

[psibi]

@loicboset LGTM. One more change: Can you add this link: #2130 (comment) to the commented out code so that others can easily discover why it's commented out ?

[loicboset]

@psibi sure! Happy to adjust anything else to comply!

Review has been addressed. It's ready to be merged.

[psibi]

Awesome. Thanks for your contribution.

[loicboset]

Awesome. Thanks for your contribution.

Thanks! I am participating this month to the Hacktoberfest, are you happy to receive more PR (quality-focus)?

[psibi]

@loicboset Sure, that would be much appreciated!