Add space force and coast guard to military #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
suggested changes
Oct 2, 2020
| marines_rank: ["Private","Private First Class","Lance Corporal","Corporal","Sergeant","Staff Sergeant","Gunnery Sergeant","Master Sergeant","First Sergeant","Master Gunnery Sergeant","Sergeant Major","Sergeant Major of the Marine Corps","Second Lieutenant","First Lieutenant","Captain","Major","Lieutenant Colonel","Colonel","Brigadier General","Major General","Lieutenant General","General"] | ||
| navy_rank: ["Seaman Recruit","Fireman Recruit","Airman Recruit","Constructionman Recruit","Seaman Apprentice","Fireman Apprentice","Airman Apprentice","Constructionman Apprentice","Seaman","Fireman","Airman","Constructionman","Petty Officer Third Class","Petty Officer Second Class","Petty Officer First Class","Chief Petty Officer","Senior Petty Officer","Master Chief Petty Officer","Command Senior Chief Petty Officer","Command Master Chief Petty Officer","Fleet Master Chief Petty Officer","Master Chief Petty Officer of the Navy","Ensign","Lieutenant","Lieutenant Commander","Commander","Captain","Rear Admiral","Vice Admiral","Admiral","Fleet Admiral","Admiral of the Navy"] | ||
| air_force_rank: ["Airman Basic","Airman First Class","Senior Airman","Staff Sergeant","Technical Sergeant","Master Sergeant","Senior Master Sergeant","Chief Master Sergeant","Command Chief Master Sergeant","Chief Master Sergeant of the Air Force","Second Lieutenant","First Lieutenant","Captain","Major","Lieutenant Colonel","Colonel","Brigadier General","Major General","Lieutenant General","General","General of the Air Force"] | ||
| dod_paygrade: ["E-1","E-2","E-3","E-4","E-5","E-6","E-7","E-8","E-9","O-1","O-2","O-3","O-4","O-5","O-6","O-7","O-8","O-9","O-10","Special"] |
Zeragamba
approved these changes
Oct 5, 2020
|
Thanks! |
|
@Zeragamba Would you be able to opt in the gem to Hacktoberfest PR count? |
|
I can't enable it on the whole repo, but I hope the PR label helps :) |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Add space force and coast guard to military * Fix silly typo
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit b4a9fb0.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit b4a9fb0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
The military generator was lacking methods for both the "Coast Guard" and the newly minted "Space Force". I also added the missing paygrades for officers with years of enlisted service as well as warrant officers. Additionally, I fixed the deprecated style format for YAML arrays on the existing data.
All details verified against https://www.wikiwand.com/en/Uniformed_services_pay_grades_of_the_United_States