Add Naruto to the JapaneseMedia category #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
suggested changes
Oct 2, 2020
lib/locales/en/naruto.yml
Outdated
| en: | ||
| faker: | ||
| naruto: | ||
| characters: ["Naruto Uzumaki", "Kakashi Hatake", "Sasuke Uchiha", "Minato Namikaze", "Obito Uchiha", "Itachi Uchiha", "Abiru", "Agara", "Agari", "Agari Kaisen", "Ageha", "Agira Ryūdōin", "Ahiko", "Aho Bird", "Aino", "Ajisai", "Akaboshi", "Akahoshi", "Akamaru", "Akane", "kane (Kunoichi)", "Akane's Father", "Akari Tatsushiro", "Akatsuchi", "Akemaru", "Akino", "Akio", "Akita Inuzuka", "Akkun", "Amachi", "Amado", "Amagi", "Amai", "Amaru", "Amayo", "Ameno", "Ameyuki", "Ameyuri Ringo", "Ami", "Amino", "Amuda", "Anato", "Anbu Commander", "Aniki", "Anko Mitarashi", "Ao", "Aoba Yamashiro", "Aoba Yamashiro", "Aoda", "Aoi (game)", "Aoi Rokushō", "Aoneko", "Arai", "Arashi", "Arashi Umeya", "Araya", "Armadiko", "Asaka", "Asaki", "Asami", "Ashimaru", "Ashina", "Ashina Uzumaki", "Ashitaba", "Asuma Sarutobi", "Asura Path (character)", "Asura Ōtsutsuki", "Atsui", "Ayame", "Azami", "Azure Fang", "Baiu", "Baji", "Baki", "Baku", "Baku (Anbu)", "Bakuto", "Bando", "Bandō", "Banna", "Bansai", "Baraki", "Baru Uchiha", "Beekeeper", "Bekkō", "Benga", "Benten", "Bird-Masked Anbu Member", "Bisuke", "Biwako Sarutobi", "Black Shadow", "Black Zetsu", "Blue B", "Boar-Masked Anbu Member", "Boro", "Boruto Uzumaki", "Boxing Kangaroos", "Breeze Dancer", "Bull", "Buna", "Bunpuku", "Buntan Kurosuki", "Bunzō", "Burami", "Buriko Nekoka", "Butsuma Senju", "Byakuren", "Captain of the Ghost Ship", "Chamaru", "Chamū", "Chen", "Chibi", "Chichiatsu", "Chikara", "Chino", "Chiriku", "Chishima", "Chiyo", "Chiyo (princess)", "Chiyomatsu", "Chōbee Akimichi", "Chōchō Akimichi", "Chōhan", "Chōji Akimichi", "Chōji's Mothe", "Chōjūrō", "Chōmei", "Chōseki", "Chōza Akimichi", "Chūji", "Chūkaku", "Chūkichi", "Chūshin", "Claw Daimyō", "Code", "Conch King", "Condor", "Crimson Fist", "Curse Jutsu Master", "Cursed Warrior", "Daen Nara", "Daibutsu", "Daichi", "Daikoku Funeno", "Daimaru", "Dajimu", "Dan Katō", "Dango Mitsuki", "Dangō", "Danjō", "Danzō Shimura", "Daore Dōtonbori", "Darui", "Datsuji", "Deepa", "Deidara", "Delta", "Demonic Statue of the Outer Path", "Dengaku", "Denka", "Denki Kaminarimon", "Disonasu", "Dodai", "Dokan", "Doki", "Dokku", "Don", "Doragu", "Dosu Kinuta", "Dotō Kazahana", "Dread Lion", "Dōshin", "Dōshu Goetsu", "Dōtō Akimichi", "Eagle-Masked Anbu Member", "Earth Daimyō", "Earth Prison Golem", "Ebisu", "Ebizō", "Ehō Norimaki", "Emi", "Emina", "Emiru", "En no Gyōja", "En Oyashiro", "Enchū Nara", "Enko Onikuma", "Enra", "Ensui Nara", "Enzo Tenrō", "Ereki Kaminarimon", "Erimaki Sharo", "Etoro Konjiki", "Evil Minister of the Tea Daimyō", "F", "Fang Daimyō", "Faz", "Fire Daimyō (Part I-II)", "First Animal Path (character)", "First Hoshikage", "Former Leader of Nadeshiko Village", "Fox-Masked Anbu Member"] |
There was a problem hiding this comment.
Please use the one item per line syntax here. (See CONTRIBUTING.md)
|
Rubocop issues need to be fixed as well |
Zeragamba
suggested changes
Oct 2, 2020
lib/locales/en/naruto.yml
Outdated
| faker: | ||
| naruto: | ||
| characters: | ||
| [ |
There was a problem hiding this comment.
we'd prefer the dash syntax for YAML files instead of brackets (See CONTRIBUTING.md)
Zeragamba
approved these changes
Oct 2, 2020
|
Thanks! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Add Naruto to the JapaneseMedia category * Fix rubocop issues * Use dash syntax for yaml arrays * Update README Co-authored-by: Stephen A. Wilson <[email protected]>
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 4a28cff.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 4a28cff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
Description: