-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup books. Add Fantasy::Tolkien to README. #2154
Conversation
@@ -28,6 +28,7 @@ development. | |||
- [Default](#default) | |||
- [Blockchain](#blockchain) | |||
- [Books](#books) | |||
- [Fantasy](#fantasy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does Fantasy
do and why do we need a new namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came in with the new Faker::Fantasy::Tolkien
. Since LotR and the Hobbit are equally popular as both movies and books, it didn't really make sense for that stuff to be in either. Since Tolkien is often attributed to being the grandfather of the modern fantasy world, I thought it was fitting to create a new namespace for it there.
We can alias some of the other fantasy stuff into Fantasy later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantasy was the new namespace I was asked to add in PR #2152 to consolidate and normalize the existing Tolkien generators (Movies::Hobbit
and Movies::LordOfTheRings
). The quotes section in these 'movie' generators betray their origin as books.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll wait for @vbrazo to approve as well.
If it's not too much trouble, I'd like to request this PR receive the |
Issue#
No-Story
Description:
This PR:
Fantasy::Tolkien
generator to the README.docs
entry toFantasy::Tolkien