Get rid of broken I18n locales configuration for the tests #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to set an empty Array to `I18n.available_locales` since
`locales_path` value becomes something like "${faker_dir}/test../lib/locales"
and so no locale files are actually found here.
vbrazo
approved these changes
Oct 20, 2020
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…y#2168) This used to set an empty Array to `I18n.available_locales` since `locales_path` value becomes something like "${faker_dir}/test../lib/locales" and so no locale files are actually found here.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…aker-ruby#2168)" This reverts commit da9fb94.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…aker-ruby#2168)" This reverts commit da9fb94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
This patch simply removes four lines of code from test_helper.rb that is currently not working as expected.
Probably since its very first introduction at 9d47686,
the code
File.expand_path(File.dirname(__FILE__) + '../lib/locales')seems not to be workingbecause
File.dirname(__FILE__)normally does not end_with a slash (unless we're on UNIX root directory...!)and so
File.dirname(__FILE__) + '../lib/locales')compiles to a broken string that doesn't point to a directory,then consequently it fails to load any locale file.
And since it doesn't do anything, we could just safely remove this block of code.
The tests shall still pass without this.