Add Faker::IDNumber.croatian_id method #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test suite fails on Ruby 2.6 with the spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-StoryDescription:
This PR adds a method for generating Croatian ID numbers (also known as OIB in Croatia) to
Faker::IDNumberclass, implemented in a similar fashion to other methods in the class.This method will be convenient to (Croatian) developers for generating valid OIBs since creating a valid number requires calculating a checksum digit according to an non-trivial algorithm specified by the ISO 7064 standard (see
croatian_id_checksum_digitmethod).When used internationally, OIB is prefixed by
HR, hence the optional argument to add the prefix.