Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add countries in Japanese #2405

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

lawriecate
Copy link
Contributor

@lawriecate lawriecate commented Oct 22, 2021

Issue#

No-Story

I'm working on a system based in Japan and we want to have test countries data in both English and Japanese!

I have tried to check this follows contribution guidelines but this is my first time so please let me know if I missed anything 🙏

Description:

Copy link
Contributor

@youpong youpong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated item "本土と属領" appears 6 times in your change.

@lawriecate
Copy link
Contributor Author

Duplicated item "本土と属領" appears 6 times in your change.

Ah thank you for catching that, I have removed it now !

@psibi psibi merged commit adc609f into faker-ruby:master Oct 26, 2021
@psibi
Copy link
Member

psibi commented Oct 26, 2021

Thank you both!

aclemons pushed a commit to aclemons/faker that referenced this pull request Mar 2, 2022
* Add countries in japanese

* Remove mainland suffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants