updated Timor-Leste in en/addresses.yml #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 28, 2022
lib/locales/en/address.yml
Outdated
| @@ -69,7 +69,7 @@ en: | |||
| DJ: "Djibouti" | |||
| DM: "Dominica" | |||
| DO: "Dominican Republic" | |||
| TP: "East Timor" | |||
| TL: "Timor-Leste" | |||
There was a problem hiding this comment.
TL: "Timor-Leste" already exists on L232. Can you remove instead of update?
https://github.com/faker-ruby/faker/pull/2452/files#diff-c0698511784659bbedc92fc0980617a69090c4729738e76e16d96b814631c01fR232
koic
reviewed
Jan 28, 2022
lib/locales/en/address.yml
Outdated
| @@ -318,7 +318,7 @@ en: | |||
| djibouti: "DJ" | |||
| dominica: "DM" | |||
| dominican_republic: "DO" | |||
| east_timor: "TP" | |||
| timor_leste: "TL" | |||
There was a problem hiding this comment.
Can you move it to the following?
thailand: "TH"
+ timor_leste: "TL"
togo: "TG"
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#2451
#2451
Description:
Corrects information for Timor-Leste in the en/addresses.yml file. Note that the country name was already changed higher up in the file, but not in the addresse by code list and its two letter country code was outdated.
please see ISO-3166-1 to confirm country code change.