Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Sora4Smash #2462

Merged
merged 1 commit into from
Mar 1, 2022
Merged

#Sora4Smash #2462

merged 1 commit into from
Mar 1, 2022

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Feb 12, 2022

Sora

Faker::Games::SuperSmashBros.fighter
=> "Sora"
Faker::Games::SuperSmashBros.stage
=> "Hollow Bastion"

Faker::Config.locale = :ja
=> :ja

Faker::Games::SuperSmashBros.fighter
=> "ソラ"
Faker::Games::SuperSmashBros.stage
=> "ホロウバスティオン"

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@psibi
Copy link
Member

psibi commented Feb 25, 2022

I think having more entries for japanese locale would be helpful.

@gazayas
Copy link
Contributor Author

gazayas commented Feb 26, 2022

@psibi Yeah I wouldn't mind doing that, maybe in another PR titled Japanese Smash Bros Locale?

@psibi psibi merged commit 8cb62c6 into faker-ruby:master Mar 1, 2022
@psibi
Copy link
Member

psibi commented Mar 1, 2022

Cool, sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants