Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add japanese translations for naruto #2479

Merged
merged 3 commits into from
Apr 17, 2022
Merged

Add japanese translations for naruto #2479

merged 3 commits into from
Apr 17, 2022

Conversation

johnmanjiro13
Copy link
Contributor

Issue#

No-Story

Description:

This PR adds japanese translations for naruto.
And I fixed typo and remove duplicated value in the english locale.

@johnmanjiro13
Copy link
Contributor Author

johnmanjiro13 commented Apr 17, 2022 •
edited
Loading

Tests failed because japanese locale of overwatch includes an english name.
It will success to rerun tests.

@psibi
Copy link
Member

psibi commented Apr 17, 2022

It will success to rerun tests.

I have re-run the jobs.

@johnmanjiro13
Copy link
Contributor Author

johnmanjiro13 commented Apr 17, 2022 •
edited
Loading

umm
I fixed the random failing test.
Could you re-run the jobs again?

@psibi psibi merged commit b1f567b into faker-ruby:master Apr 17, 2022
@psibi
Copy link
Member

psibi commented Apr 17, 2022

Thank you!

@johnmanjiro13 johnmanjiro13 deleted the ja-translation-naruto branch April 17, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnmanjiro13 @psibi