Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add automotive data #254

Closed
wants to merge 4 commits into from
Closed

add automotive data #254

wants to merge 4 commits into from

Conversation

haruska
Copy link

@haruska haruska commented Sep 3, 2014

This adds faker data for autos.

@ivanovaleksey
Copy link

Hi everyone.
It seems like there is no any activity here for a long time.
Will this PR useful for others?
Should I try to refresh it?

@oyeanuj
Copy link
Contributor

oyeanuj commented Sep 10, 2016

@ivanovaleksey +1

@ivanovaleksey
Copy link

ivanovaleksey commented Sep 11, 2016 •
edited
Loading

@oyeanuj do you mean that I should can do it? =)

@ivanovaleksey ivanovaleksey mentioned this pull request Sep 14, 2016
Closed
1 task
@ivanovaleksey
Copy link

I fixed specs and some methods and opened #692

vbrazo
vbrazo reviewed May 15, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 🥇
Could you guys rebase the branch and fix the Travis issues?
Please let me know when it's ready for review again.

@haruska
Copy link
Author

haruska commented May 15, 2018

This is 3.5 years old. I no longer need this pulled into faker. Happy to have @ivanovaleksey take the ball on #692

@haruska haruska closed this May 15, 2018
@vbrazo
Copy link
Member

vbrazo commented May 15, 2018

Amazing. Thanks for the follow-up @haruska

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo left review comments

Assignees

@haruska haruska

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haruska @ivanovaleksey @oyeanuj @vbrazo