Update sport docs #2687
Update sport docs #2687
Conversation
There was a problem hiding this comment.
thank you @clementf good catch!
Have you considered also updating the test file? It's also using Faker::Sports.
|
Closing this as there has not been activity for the past 2 weeks. Feel free to reopen anytime. Thanks! |
|
@stefannibrasil thank you for the feedback; and apologies for the delayed reply. When you say updating the test file, do you mean turning |
|
@clementf no worries, thanks for the interest in helping out! Yes, you're right. Since we are updating the generator, it's important to update the tests as well. Thank you! |
|
@stefannibrasil you're right indeed, I had overlooked those test files. I made the necessary changes, could you reopen the PR? |
|
@clementf thank you! I can't reopen it because it says this branch has been force-pushed or recreated. I also didn't see the test changes in this PR. Maybe there is another branch that does not an open PR yet? If so, feel free to open a new PR and mention this PR on the description. Thanks! |
|
@stefannibrasil I did rebase to include the changes from the main branch, I'm guessing this is the reason. I've opened another PR at #2716 |
|
all good, thanks! |
Summary
This PR contains only a documentation change. I've noticed recently while using faker that all the examples in the docs for the
Faker::Sportclass contain a typo (they have an additionalsin the class name).PS: thank you for creating, and maintaining this ruby gem, which I've been using in a lot of projects!