Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Archer into tv category. #2750

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Added Archer into tv category. #2750

merged 2 commits into from
Jul 2, 2023

Conversation

lepari23
Copy link
Contributor

Summary

Added Archer characters, locations and quotes to tv shows.

"I swear to god I had something for this."

thdaraujo
thdaraujo requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this! Left a comment.

lib/faker/tv_shows/archer.rb Outdated Show resolved Hide resolved
@lepari23 lepari23 requested a review from thdaraujo June 29, 2023 15:48
thdaraujo
thdaraujo approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thdaraujo thdaraujo merged commit a9620b2 into faker-ruby:main Jul 2, 2023
@lepari23 lepari23 deleted the add-archer branch July 3, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

@lepari23 lepari23

Labels
⭐ PR: Feature 🏃🏽 PR: In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lepari23 @thdaraujo