Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor 'The Room' instead of 'Room' #2854

Merged
merged 1 commit into from
Nov 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions doc/movies/room.md

This file was deleted.

11 changes: 11 additions & 0 deletions doc/movies/the_room.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Faker::Movies::TheRoom

```ruby
Faker::Movies::TheRoom.actor #=> "Tommy Wiseau"

Faker::Movies::TheRoom.character #=> "Johnny"

Faker::Movies::TheRoom.location #=> "Johnny's Apartment"

Faker::Movies::TheRoom.quote #=> "A-ha-ha-ha! What a story, Mark!"
```
8 changes: 4 additions & 4 deletions lib/faker/movies/room.rb → lib/faker/movies/the_room.rb
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ class << self
#
# @faker.version next
def actor
fetch('room.actors')
fetch('the_room.actors')
end

##
@@ -27,7 +27,7 @@ def actor
#
# @faker.version next
def character
fetch('room.characters')
fetch('the_room.characters')
end

##
@@ -40,7 +40,7 @@ def character
#
# @faker.version next
def location
fetch('room.locations')
fetch('the_room.locations')
end

##
@@ -55,7 +55,7 @@ def location
#
# @faker.version next
def quote
fetch('room.quotes')
fetch('the_room.quotes')
end
end
end
2 changes: 1 addition & 1 deletion lib/locales/en/room.yml → lib/locales/en/the_room.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
en:
faker:
room:
the_room:
actors:
- Tommy Wiseau
- Juliette Danielle
File renamed without changes.