Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condominium_fiscal_code generator length from 9 to 11 characters #3037

Merged

Conversation

FiloSpaTeam
Copy link
Contributor

Motivation / Background

This Pull Request has been created because the real length of a condominium fiscal_code in Italy is 11 and not 9: the first 7 numbers identify the condominium, the later 3 identify the office and the latest is the control character

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

Sorry, something went wrong.

@FiloSpaTeam FiloSpaTeam changed the title fix condominium_fiscal_code generator fix condominium_fiscal_code generator length from 9 to 11 characters Dec 17, 2024
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a link to where the length is documented? I couldn't find anything about it to have enough information to review this. Thank you!

@stefannibrasil stefannibrasil added ⌛ PR: Needs More Information When the author needs to provide more information and removed ⏲️ PR: In Queue for Review labels Jan 8, 2025
@FiloSpaTeam
Copy link
Contributor Author

Could you provide a link to where the length is documented? I couldn't find anything about it to have enough information to review this. Thank you!

https://www.agenziaentrate.gov.it/portale/documents/20143/296761/Provvedimento+06022018+-+30383_Allegato%2B1%2BPROVV.%2BPROT.%2BR.U.%2B30383.pdf/5979fb41-5ca3-d5de-8935-96d309a567ed

The condominium is a juridical person so has 11 character length (only number). Check page 4 (italian version but from Agenzia delle Entrate)

image

@FiloSpaTeam FiloSpaTeam force-pushed the fix/condominium_fiscal_code branch from a21ac40 to c42cbec Compare January 8, 2025 15:09
the real length of a condominium fiscal_code is 11 and not 9: the first 7 numbers identify the condominium, the later 3 identify the office and the latest is the control character
@FiloSpaTeam FiloSpaTeam force-pushed the fix/condominium_fiscal_code branch from c42cbec to b379861 Compare January 10, 2025 08:38
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for providing more context 👍🏼

@stefannibrasil stefannibrasil removed the ⌛ PR: Needs More Information When the author needs to provide more information label Jan 15, 2025
@stefannibrasil stefannibrasil merged commit 7acfda6 into faker-ruby:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants