Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Hipster methods to use named parameters to improve readability. #742

Conversation

tiagofsilva
Copy link
Contributor

  • This PR breaks backwards compatibility with the previous version of the Hipster class.
  • This is just a fair simple refactoring on one class and its test. That's why I didn't create any extra tests as specified in the contributing.md document.

@stympy
Copy link
Contributor

stympy commented Dec 17, 2016

I'm going to hold off on this one until I'm ready for a major release to break backwards compatibility. In that release we'll change everything to use named parameters.

@stympy stympy added this to the 2.0 milestone Dec 17, 2016
@tiagofsilva
Copy link
Contributor Author

Great, @stympy! Knowing that, I'll be working on changing more classes to named parameters then.

@vbrazo vbrazo force-pushed the master branch 5 times, most recently from a359def to a5d7731 Compare May 22, 2018 21:15
@vbrazo vbrazo mentioned this pull request Sep 4, 2018
@vbrazo
Copy link
Member

vbrazo commented Oct 19, 2018

Since we're migrating the objects to namespaces #1318, we'll change the arguments to keywords/named params while adding the namespaces. I think it'd be a better idea to concentrate all the changes in this transition instead of doing things separately. Thanks for opening this PR and suggesting this change.

@vbrazo vbrazo closed this Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants