Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Yandex Data Streams support #355

Conversation

preved911
Copy link

Hello. This changes are need too if PR will merged.

@poiana
Copy link
Contributor

poiana commented Jun 20, 2022

Welcome @preved911! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from bencer and leogr June 20, 2022 13:53
@poiana
Copy link
Contributor

poiana commented Jun 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: preved911
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@preved911 preved911 changed the title added Yandex Data Streams support Adding Yandex Data Streams support Jun 20, 2022
@poiana poiana added the size/L label Jun 20, 2022
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch 2 times, most recently from f4ad364 to 8e44a6b Compare June 20, 2022 14:00
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your broke the lines about minimumpriority of the table in the README.
Moreover, wait for next release of Falcosidekick, the support of Yandex Data Streams will not be available before and I need to review falcosecurity/falcosidekick#336 first.

@Issif
Copy link
Member

Issif commented Jun 20, 2022

/do-not-merge

@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch 2 times, most recently from 53d42cf to d912a3c Compare June 20, 2022 18:15
Signed-off-by: Ildar Valiullin <[email protected]>
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch from d912a3c to 15529f5 Compare June 20, 2022 18:19
@preved911 preved911 marked this pull request as ready for review June 22, 2022 12:47
@poiana poiana requested a review from Issif June 22, 2022 12:47
@Lowaiz
Copy link
Contributor

Lowaiz commented Aug 2, 2022

Superseeded by #378

@poiana
Copy link
Contributor

poiana commented Oct 31, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Nov 30, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants