feat(decl): make rule and expectedOutcome conditionally optional
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make rule and expectedOutcome not required upon `declarative run` and `declarative test --skip-outcome-verification` commands invocation. Signed-off-by: Leonardo Di Giovanna <[email protected]>
|
LGTM label has been added. Git tree hash: 87288e3881bed94ffb54372733df5c620bd11321
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
poiana
merged commit d5c1568
into
falcosecurity:declarative-testing
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
This PR conditionally makes the
ruleandexpectedOutcomefields optional in the YAML tests description.If the user run a test through the
declarative runcommand or, equivalently, thedeclarative test --skip-outcome-verificationcommand, these fields are ignored.If the user run a test through
declarative testcommand, therulefield is mandatory, and an emptyexpectedOutcomematches any outcome resulting from the application of the test actions.Which issue(s) this PR fixes:
Fixes #257
Special notes for your reviewer: