-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(REPOSITORIES.md): revising repositories "scope" and "status" #273
Conversation
Great @leogr and thank you! /lgtm |
@leogr 🤯 🤩 ❤️ this is truly amazing work!!! Loving it! We could consider removing the gif from the README plus perhaps we could enhance the descriptions of the repositories to something just slightly longer / more expressive (elevator pitch like why should I care? what do I get out of this repo?) if it makes sense similar to the changes we just made to the main Falco README. On that note, we can iterate on what the perfect a bit longer description per repo should be and as a result update the Falco README and all other repos to have them all in sync -> could be combined with the PRs that add the new badges to each repo. |
Signed-off-by: Leonardo Grasso <[email protected]>
…" to "stable" Signed-off-by: Leonardo Grasso <[email protected]>
…more This an editorial change to keep the document up to date with obvious external changes. Previously, "core" and "official" were used as synonyms. Now that we split statuses from scopes, the principle of core repository only applies to the scope. Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Because of the split, this commit also assigns scope and status based on the new criteria. In particular, we assume that the following repos can be considered stable: - falco-exporter - falcosidekick - test-infra Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
3beca7e
to
4463668
Compare
This one? 😿
Good idea. I'll try to fix it soon. Anyway, consider we can always improve those descriptions later.
Please note that GitHub will show those descriptions in the left column at the top. 👇 I don't believe we also have to report them in each repo readme. |
Signed-off-by: Leonardo Grasso <[email protected]>
Last update: I just revised repositories descriptions as suggested by @incertum @falcosecurity/evolution-maintainers To get a preview 👇 After this PR gets merged, we can add badges to the README of all repos 🤩 cc @falcosecurity/core-maintainers |
@leogr LGTM, thank you! Agreed we can tweak the descriptions over time. Proposing to proceed. |
Looks great to me @leogr! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
What this PR does / why we need it:
For context, see #271
This PR:
Which issue(s) this PR fixes:
Contribute to #271 but not completely address it.
Special notes for your reviewer:
This PR modifies the status or scope of some repositories to reflect the new criteria. As per our governance, this change is allowed just using lazy consensus since no core repositories have been touched. But, in case you disagree with the new categorization, just let me know.