Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(rules): document enabled-only rule definitions #515

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

jasondellaluce
Copy link
Contributor

Signed-off-by: Jason Dellaluce [email protected]

What type of PR is this?

/kind content

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

This updates the rule docs to follow up the changes introduced in falcosecurity/falco#1775.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However, this PR should not be merged before the next Falco release (0.31.0), so:
/hold

Feel free to cancel the hold once the feature is out in Falco 0.31.0

@poiana
Copy link

poiana commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Nov 17, 2021
@poiana
Copy link

poiana commented Nov 17, 2021

LGTM label has been added.

Git tree hash: 0505f7d740c8f3cdedff6f28e9afadadcd570d53

@leogr leogr changed the title wip: doc(rules): document enabled-only rule definitions doc(rules): document enabled-only rule definitions Jan 17, 2022
@leogr
Copy link
Member

leogr commented Jan 31, 2022

/unhold

@poiana poiana merged commit ade2081 into falcosecurity:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants