-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(docker): remove minimal
image
#1196
Conversation
/hold |
LGTM label has been added. Git tree hash: ae5cfbd55fc6daa33e2042eac223a10aab05d09f
|
/hold cancel |
Signed-off-by: Leonardo Grasso <[email protected]>
211de93
to
cbac1d2
Compare
Rebased. |
LGTM label has been added. Git tree hash: b81a7c94ce6288a76ee79324b7da12a981b40da6
|
/honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I just found this PR and it makes me a little bit sad. This image was a cool experiment made @mfdii. The goal was to reduce the amount of packages shipped in the Falco container image to easily pass container images scanners like Clair or Snyk. A quick scan with Snyk of the falcosecurity/falco:0.22.1-slim Docker image reveals there are 103 known vulnerabilities in the image. The "minimal" image fixed that. |
Hey @JPLachance I believe we can do this before the next release. |
Great then! I'll be happy to test te new image once we will have a way to load the probe :D |
Signed-off-by: Leonardo Grasso [email protected]
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
As per "Falco Artifacts Scope" proposal 👉 #1184
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
PS
Since the multi-stage build approach used by this minimal image seems still valid to me, I would propose - in another PR - to refactor the current
docker/slim/Dockerfile
in the same way but once we have decided the proper naming of these images./cc @fntlnz
/cc @kris-nova
/cc @leodido
Does this PR introduce a user-facing change?: