Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule(list allowed_k8s_users): add "kubernetes-admin" user #1323

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Jul 21, 2020

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Since kubernetes-admin user is included in some k8s distribution by (it is also used by kubadm and kind), I believe it should be included in the allowed k8s users' list.

Which issue(s) this PR fixes:

Fixes #1186

Special notes for your reviewer:

I've noticed that using kind. Without kubernetes-admin, Falco is triggering an alert for any activity performed by kind.

/milestone 0.25.0

Does this PR introduce a user-facing change?:

rule(list allowed_k8s_users): add "kubernetes-admin" user

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the list full_admin_k8s_users here?

@leogr
Copy link
Member Author

leogr commented Jul 22, 2020

Can we use the list full_admin_k8s_users here?

TBH, I'm not sure about that. allowed_k8s_users is used just by one rule (Disallowed K8s User). On the other hand, full_admin_k8s_users seems to be not used. It might be a typo: note the difference between full_admin_k8s_users and admin_k8s_users in the rule condition (the full_ prefix is missing).

cc @Kaizhe @mstemm @vicenteherrera
Any ideas?

@Kaizhe
Copy link
Contributor

Kaizhe commented Jul 24, 2020

/lgtm

@poiana
Copy link
Contributor

poiana commented Jul 24, 2020

LGTM label has been added.

Git tree hash: 4e1a01edd639cb4f39ec232c4d441c91fde38ec8

@poiana
Copy link
Contributor

poiana commented Jul 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, Kaizhe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f1a42cf into master Jul 25, 2020
@poiana poiana deleted the rule/allow-kubernetes-admin branch July 25, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule not working: Create/Modify Configmap With Private Credentials
4 participants