-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule(list allowed_k8s_users): add "kubernetes-admin" user #1323
Conversation
Signed-off-by: Leonardo Grasso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the list full_admin_k8s_users
here?
TBH, I'm not sure about that. cc @Kaizhe @mstemm @vicenteherrera |
/lgtm |
LGTM label has been added. Git tree hash: 4e1a01edd639cb4f39ec232c4d441c91fde38ec8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, Kaizhe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Since
kubernetes-admin
user is included in some k8s distribution by (it is also used by kubadm and kind), I believe it should be included in the allowed k8s users' list.Which issue(s) this PR fixes:
Fixes #1186
Special notes for your reviewer:
I've noticed that using kind. Without
kubernetes-admin
, Falco is triggering an alert for any activity performed bykind
./milestone 0.25.0
Does this PR introduce a user-facing change?: