macro(user_read_sensitive_file_containers): replace endswiths with ex… #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
previously approved these changes
Aug 12, 2020
|
LGTM label has been added. Git tree hash: d42cef16217d57157fae3b553d22296124cda3d1
|
…act image repo name macro(user_trusted_containers): replace endswiths with exact image repo name macro(user_privileged_containers): replace endswiths with exact image repo name macro(trusted_images_query_miner_domain_dns): replace endswiths with exact image repo name macro(falco_privileged_containers): append "/" to quay.io/sysdig list(falco_privileged_images): add images docker.io/sysdig/agent-slim and docker.io/sysdig/node-image-analyzer list(falco_sensitive_mount_images): add image docker.io/sysdig/agent-slim list(k8s_containers): prepend docker.io to images Signed-off-by: kaizhe <[email protected]>
Signed-off-by: kaizhe <[email protected]>
Signed-off-by: kaizhe <[email protected]>
Signed-off-by: kaizhe <[email protected]>
Signed-off-by: kaizhe <[email protected]>
Kaizhe
force-pushed
the
kh_fix-ends-with-image
branch
from
e7e17f6 to
b08563c
Compare
fntlnz
approved these changes
Aug 13, 2020
|
LGTM label has been added. Git tree hash: 39ca1d9c7feb841545732e387c55afa3999e120c
|
mstemm
approved these changes
Aug 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…act image repo name
macro(user_trusted_containers): replace endswiths with exact image repo name
macro(user_privileged_containers): replace endswiths with exact image repo name
macro(trusted_images_query_miner_domain_dns): replace endswiths with exact image repo name
macro(falco_privileged_containers): append "/" to quay.io/sysdig
list(falco_privileged_images): add images docker.io/sysdig/agent-slim and docker.io/sysdig/node-image-analyzer
list(falco_sensitive_mount_images): add image docker.io/sysdig/agent-slim
list(k8s_containers): prepend docker.io to images
Signed-off-by: kaizhe [email protected]
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Reduce false negative
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: