build: remove macrodefs about time (musl build) #1400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
See draios/sysdig#1684 Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
chore/remove-time-macrodefs
branch
from
fc0b6c8 to
3bedcc4
Compare
|
I'm closing this PR, and opening a new one that includes all latest fixes on sysdig (it also solve the problem reported by #1409) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area engine
What this PR does / why we need it:
This PR follows up draios/sysdig#1684.
It just includes the above ☝️ fix done by @leodido and @fntlnz by updating the driver version, then clean ups macros that now become unnecessary.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @fntlnz
/cc @leodido
Does this PR introduce a user-facing change?: