-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add known k8s service accounts #1659
Conversation
Welcome @sboschman! It looks like this is your first PR to falcosecurity/falco 🎉 |
ea58acb
to
4477104
Compare
Signed-off-by: Sverre Boschman
4477104
to
02675cd
Compare
/milestone 0.29.0 |
/lgtm |
LGTM label has been added. Git tree hash: af48f3e2e92b9194331f67c93a99e5cc75a21ec5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone 0.29.0
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind rule-update
/area rules
What this PR does / why we need it:
Add namespace-controller, statefulset-controller, disruption-controller, job-controller, horizontal-pod-autoscaler and persistent-volume-binder as additional default k8s controller service accounts to the
known_sa_list
list. This addition prevents these controllers from triggering a warning as they are created in the kube-system namespace.These controllers are default k8s controllers according to the docs (https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/)