-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new miner pools to miner domain lists to improve detection #1729
Conversation
Signed-off-by: Alberto Pellitteri <[email protected]> Co-authored-by: darryk10 <[email protected]>
Signed-off-by: Alberto Pellitteri <[email protected]> Co-authored-by: darryk10 <[email protected]>
Welcome @AlbertoPellitteri! It looks like this is your first PR to falcosecurity/falco 🎉 |
2 similar comments
Welcome @AlbertoPellitteri! It looks like this is your first PR to falcosecurity/falco 🎉 |
Welcome @AlbertoPellitteri! It looks like this is your first PR to falcosecurity/falco 🎉 |
/assign @mstemm |
rules/falco_rules.yaml
Outdated
"xmr.crypto-pool.fr" | ||
"xmr.crypto-pool.fr", | ||
"ss.antpool.com", | ||
"stratum-dash.antpool.com.antpool.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should stratum-dash.antpool.com.antpool.com
be stratum-dash.antpool.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Typo fixed.
Co-authored-by: darryk10 <[email protected]> Signed-off-by: Alberto Pellitteri <[email protected]>
/milestone 0.30.0 |
LGTM label has been added. Git tree hash: d042c1e4b368db92491055085b7c16d09100c6b0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlbertoPellitteri, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alberto Pellitteri [email protected]
Co-authored-by: darryk10 [email protected]
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Found and added some new miner pools that enhance miner detection.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: