style(userspace/engine): avoid creating multiple versions of methods only to assume default ruleset. Use a default argument instead. #1754
Conversation
|
Welcome @FedeDP! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…only to assume default ruleset. Use a default argument instead. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Mark Stemm <[email protected]>
FedeDP
force-pushed
the
cleanup_m_default_ruleset
branch
from
5afb891 to
fc8d716
Compare
|
LGTM label has been added. Git tree hash: a9cf792f1732d0079c2297ba402c90adc016bb61
|
|
Closing and reopening to trigger the CI |
|
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/milestone 0.31.0 |
Signed-off-by: Federico Di Pierro <[email protected]>What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Avoid creating multiple methods to only route that m_default_ruleset to main method; properly use a default argument instead.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: