Cleanup list fields #1816
Merged
Cleanup list fields #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
force-pushed
the
cleanup-list-fields
branch
from
eae9afa to
0c0ab65
Compare
mstemm
force-pushed
the
cleanup-list-fields
branch
from
0c0ab65 to
f2c8e68
Compare
Instead of having a falco-specific function to print field info, use the built-in filter_fieldclass_info::as_string() instead. This is a better implementation (displays addl info, has better wrapping, wider output) and having a single implementation allows for consistent outputs between falco and other potential programs that could use the libs. Signed-off-by: Mark Stemm <[email protected]>
With the new implementation of list_fields(), the order of fields changed slightly. So update the checksum. Signed-off-by: Mark Stemm <[email protected]>
Update json_event_filter_factory::get_fields() to add the new info (shortdesc, data_type, tags) to field descriptions. This allows for richer outputs when printing info on the fields. Signed-off-by: Mark Stemm <[email protected]>
This has required changes to print info on fields. Signed-off-by: Mark Stemm <[email protected]>
mstemm
force-pushed
the
cleanup-list-fields
branch
from
f2c8e68 to
aa7e3e1
Compare
|
/milestone 0.31.0 |
jasondellaluce
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
LGTM
For more context, this is built on top of the changes of falcosecurity/libs#153 and aligns Falco to them.
|
LGTM label has been added. Git tree hash: 045b1387804ffac6b3a56bd337982e42204bc43d
|
|
/milestone 0.31.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: