fix: force-set evt.type for plugin source events #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or "plugin" source events. This workaround an issue in libs, targeting Falco 0.31.0. Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Leonardo Grasso <[email protected]> Co-authored-by: Jason Dellaluce <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected] Signed-off-by: Leonardo Grasso <[email protected]>
… plugin versions. Signed-off-by: Federico Di Pierro <[email protected]>
|
Hoping this is the last set of last-minute fixes for this release /milestone 0.31.0 Huge thank you to @FedeDP and @jasondellaluce 🤗 |
…is used by caller. Signed-off-by: Federico Di Pierro <[email protected]>
|
LGTM label has been added. Git tree hash: 68e5c3f748006accf74da48aaf3dc2c3edf16bc0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
This completes the changes of #1875, by introducing protective logic on for the
evttypes()method for the edge case of sources coming from plugins andk8s_audit. This prevents rules written from those sources to be unwillingly excluded from the rule index, which caused them to never match on any event.This also bumps the plugin versions to the latest released versions, both in the CMake dependencies an in the
aws_cloudtrail_rules.yamlruleset.Finally, semver check for required plugin versions has been added.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: