-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(userspace/falco): applies FALCO_INSTALL_CONF_FILE as the default … #1900
fix(userspace/falco): applies FALCO_INSTALL_CONF_FILE as the default … #1900
Conversation
5996fd6
to
945901b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Your solution works, but I'd rather keep the old behavior when -DCMAKE_BUILD_TYPE=Debug
and use only the installation path when -DCMAKE_BUILD_TYPE=Release
.
Wdyt? :)
945901b
to
b1f994e
Compare
/milestone 0.32.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @jasondellaluce comment.
b1f994e
to
e626668
Compare
…config. Signed-off-by: Andrea Bonanno <[email protected]>
e626668
to
4c21a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: af480455ac3cfd10a884e025c506125f0142382f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreabonanno, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…config.
Signed-off-by: Andrea Bonanno [email protected]
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it:
Makes Falco defaults to the config file in
/etc/falco/falco.yaml
when the-c
option is not used, instead of evaluating/source/falco/falco.yaml
as the config source with highest priority.Which issue(s) this PR fixes:
Fixes #1897
Special notes for your reviewer:
Does this PR introduce a user-facing change?: