Ignore unknown sources rules macros #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a rule has an unknown source, *and* has exceptions, loading the rule will result in an error and not skipping the rule. This is because exceptions are also validated for unknown fields, and that occurs before the current check for unknown sources. The fix is to move the check for unknown sources as soon as the rules object is read. Signed-off-by: Mark Stemm <[email protected]>
Also skip macros with unknown sources. This matters primarily for macros related to plugins that have a distinct event source. Signed-off-by: Mark Stemm <[email protected]>
Add new test cases for a rule with an unknown source *and* an exception, and a macro with an unknown source. The first results in a rule warning (and no error), and the second prints an error and skips. Signed-off-by: Mark Stemm <[email protected]>
|
/milestone 0.32.0 |
|
LGTM label has been added. Git tree hash: 5fa465531de61503ca7d405170f5c96f5103cf11
|
|
/milestone 0.32.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Fix a bug where rules with unknown sources and exceptions, or macros with unknown sources, resulted in errors instead of warnings.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: