rule(k8s): secret get detection for both successful and unsuccessful attempts #1949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Furkan [email protected]
Success case: (ERROR)
Fail case: (WARNING):
What type of PR is this?
/kind rule-create
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I don't add
non_system_user
condition because in general practice, cluster admins deploys cluster role (i.e., with restricted role) intokube-system
namespace. Which would ended up false-negative. I think we should remove this condition in both secretcreate
anddelete
rules.Does this PR introduce a user-facing change?:
NONE