Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete or rename shell history: .ash_history #1956

Merged
merged 3 commits into from
May 14, 2022
Merged

Delete or rename shell history: .ash_history #1956

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8765eeb
rule(macro modify_shell_history): include .ash_history
bdashrad Mar 23, 2022
95a6e0d
rule(macro truncate_shell_history): include .ash_history
bdashrad Mar 23, 2022
d345600
use endswith ash_history to catch both bash and ash
bdashrad May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rules/falco_rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2575,22 +2575,26 @@
evt.arg.name endswith "zsh_history" or
evt.arg.name contains "fish_read_history" or
evt.arg.name endswith "fish_history" or
evt.arg.name contains "ash_history" or
evt.arg.oldpath contains "bash_history" or
evt.arg.oldpath endswith "zsh_history" or
evt.arg.oldpath contains "fish_read_history" or
evt.arg.oldpath endswith "fish_history" or
evt.arg.oldpath contains "ash_history" or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be possible to use endswith operator instead of contains?
Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @darryk10 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we introduce ash_history (doesn't matter whether using operator contains or endswith), we can ignore the bash_history then. A proper comment will be useful here saying both bash_history and ash_history will be covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable approach to me. Do we still want to use contains or do we want to change it to endswith. I don't have a preference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed up a change

evt.arg.path contains "bash_history" or
evt.arg.path endswith "zsh_history" or
evt.arg.path contains "fish_read_history" or
evt.arg.path endswith "fish_history"))
evt.arg.path endswith "fish_history" or
evt.arg.path contains "ash_history"))

- macro: truncate_shell_history
condition: >
(open_write and (
fd.name contains "bash_history" or
fd.name endswith "zsh_history" or
fd.name contains "fish_read_history" or
fd.name endswith "fish_history") and evt.arg.flags contains "O_TRUNC")
fd.name endswith "fish_history" or
fd.name contains "ash_history") and evt.arg.flags contains "O_TRUNC")

- macro: var_lib_docker_filepath
condition: (evt.arg.name startswith /var/lib/docker or fd.name startswith /var/lib/docker)
Expand Down