Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: whitelist GCP's container threat detection image #1959

Merged
merged 2 commits into from
Apr 15, 2022
Merged

rules: whitelist GCP's container threat detection image #1959

merged 2 commits into from
Apr 15, 2022

Conversation

clmssz
Copy link
Contributor

@clmssz clmssz commented Mar 25, 2022

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Container threat detection is a feature of GCP security center that monitors cos nodes for changes and remote access attempts (it kinds of duplicate falco). It spawns a privileged DaemonSet in GKE clusters kube-system namespace, hence the need for ignoring this image.

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Mar 25, 2022

Welcome @clmssz! It looks like this is your first PR to falcosecurity/falco 🎉

@jasondellaluce
Copy link
Contributor

Thank you for this, I think this works! @Kaizhe WDYT?

@Kaizhe
Copy link
Contributor

Kaizhe commented Mar 29, 2022

@poiana
Copy link
Contributor

poiana commented Mar 29, 2022

LGTM label has been added.

Git tree hash: 39bdf1269664d311db07f0829c79edde8f26b7fd

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clmssz, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit af96a93 into falcosecurity:master Apr 15, 2022
@jasondellaluce
Copy link
Contributor

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants