Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #1961

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix some typos #1961

merged 1 commit into from
Apr 6, 2022

Conversation

invidian
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Fixing some typos found while browsing other projects shipping the rules.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Found by running the following command:
codespell -f -H -L aks,creat,chage -S .git

I can also add a GitHub Action using the command above to prevent more typos being added in the future.

Does this PR introduce a user-facing change?:

NONE

Found by running the following command:
codespell -f -H -L aks,creat,chage -S .git

Signed-off-by: Mateusz Gozdek <[email protected]>
@poiana
Copy link
Contributor

poiana commented Mar 28, 2022

Welcome @invidian! It looks like this is your first PR to falcosecurity/falco 🎉

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for this! 😄 I think adding a GitHub Action for this would be a great contribution. Would you like to open a PR for it to gather some feedback? 🙏🏼

@poiana
Copy link
Contributor

poiana commented Mar 29, 2022

LGTM label has been added.

Git tree hash: c2ba65f86f7ddda1a035b4d59ca6b3be5d58b040

invidian added a commit to kinvolk/falco that referenced this pull request Mar 29, 2022
Folllow up to falcosecurity#1961 to prevent common typos to be added to the repo.

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian
Copy link
Contributor Author

Thank you for this! smile I think adding a GitHub Action for this would be a great contribution. Would you like to open a PR for it to gather some feedback? 🙏🏼

Thanks for review and approval. I opened #1962 then ;)

@leogr
Copy link
Member

leogr commented Apr 6, 2022

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Apr 6, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invidian, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cb4cec6 into falcosecurity:master Apr 6, 2022
@invidian invidian deleted the invidian/fix-typos branch April 6, 2022 14:07
invidian added a commit to kinvolk/falco that referenced this pull request Apr 16, 2022
Folllow up to falcosecurity#1961 to prevent common typos to be added to the repo.

Signed-off-by: Mateusz Gozdek <[email protected]>
poiana pushed a commit that referenced this pull request Apr 20, 2022
Folllow up to #1961 to prevent common typos to be added to the repo.

Signed-off-by: Mateusz Gozdek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants