Circle CI build job for ARM64 #1997

odidev · 2022-05-10T13:47:49Z

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:
Added Circle CI job to build Falco for ARM64 platform.

Which issue(s) this PR fixes:

Fixes #1891

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

poiana · 2022-05-10T13:47:57Z

Welcome @odidev! It looks like this is your first PR to falcosecurity/falco 🎉

FedeDP · 2022-05-10T14:02:52Z

.circleci/config.yml

+    machine:
+      enabled: true
+      image: ubuntu-2004:202101-01
+    resource-class: arm.medium


This should be resource_class, note the underscore.

FedeDP · 2022-05-10T14:09:45Z

.circleci/config.yml

@@ -357,11 +381,13 @@ jobs:
          command: |
            FALCO_VERSION=$(cat /build/release/userspace/falco/config_falco.h | grep 'FALCO_VERSION ' | cut -d' ' -f3 | sed -e 's/^"//' -e 's/"$//')
            /source/falco/scripts/publish-rpm -f /build/release/falco-${FALCO_VERSION}-x86_64.rpm -r rpm-dev
+            /source/falco/scripts/publish-rpm -f /build/release/falco-${FALCO_VERSION}-aarch64.rpm -r rpm-dev


The same lines must be added also to publish/packages and publish/packages-deb job, again except for the bin static one.

Thanks for suggestion, added the same.

FedeDP · 2022-05-10T14:12:45Z

So, we surely need to port publish-deb script.
As you can see, publish-bin already takes architecture as argument. I think we must do the same with publish-deb:
basically, on this line: https://github.com/falcosecurity/falco/blob/master/scripts/publish-deb#L41 you must check the external argument provided instead of declaring a local variable.

publish-rpm does not seem to reference x86_64 or any uname variable, therefore i guess we shouldn't touch it.

I will need someone else to review the workflow too :) It seems fine to me:

Build and test workflow

we have the build-arm64 job that builds and stores artifacts for arm64
build-arm64 is required by rpm-sign that is itself required by publish/packages-dev
build-arm64 is also required by publish/packages-deb-dev

[ build-arm64 ]  -> [ rpm-sign ] -> [ publish/packages-dev ]
                 |----------------> [ publish/packages-deb-dev ]

Release workflow

we have the build-arm64 job that builds and stores artifacts for arm64
build-arm64 is required by rpm-sign that is itself required by publish/packages
build-arm64 is also required by publish/packages-deb

[ build-arm64 ]  -> [ rpm-sign ] -> [ publish/packages ]
                 |----------------> [ publish/packages-deb ]

EDIT: i also left a couple of comments that need to be addressed :)
Thanks btw!!

FedeDP · 2022-05-10T15:27:45Z

To maintainers: note that the build-arm64 job will never work unless the falcosecturity/falco-builder:latest image is available for arm64; that's part of #1990!

FedeDP · 2022-05-11T09:27:09Z

@odidev it seems like the new v2.1 workflows version is breaking the build:

 # [#/jobs/driver-loader~1integration] string [driver-loader/integration] does not match pattern ^[A-Za-z][A-Za-z\\s\\d_-]*$

Can you revert to 2?

Moreover, can you set "Fixes #1891" in the OP?

FedeDP · 2022-05-12T07:51:40Z

Given that this PR depends upon #1990 , if you wish i can take over the publish scripts part; then you will need to rebase this one, once my PR is reviewed and eventually merged.
WDYT?

odidev · 2022-05-12T08:19:37Z

Can you revert to 2?

Usage of arm resources makes it mandatory to use workflow 2.1 . I checked out the error its nothing major, changing the name of the job should do the trick, I think it would better to mark this as WIP as it still might need some more modifications based on version 2.1 which can be figured only when we are able to run it. We can focus on releasing docker images and binary for arm64 for now.

Moreover, can you set "Fixes #1891" in the OP?

The issue is for getting testing enabled for arm64, currently we are skipping it. Once we are able to add it too we can probably close it.

Given that this PR depends upon #1990 , if you wish i can take over the publish scripts part; then you will need to rebase this one, once my PR is reviewed and eventually merged.
WDYT?

Sure thing.

FedeDP · 2022-05-12T08:23:29Z

The issue is for getting testing enabled for arm64

Mmh aren't we actually testing it? https://github.com/falcosecurity/falco/pull/1997/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R14

Usage of arm resources makes it mandatory to use workflow 2.1

Oh i see thanks! Yeah renaming the job should do the trick; i think you can proceed with that!

FedeDP · 2022-05-13T09:38:57Z

@odidev i updated #1990 fixing publishing (deb,rpm) scripts.
They must be used like this:

/source/falco/scripts/publish-rpm -f /build/release/falco-${FALCO_VERSION}-x86_64.rpm -f /build/release/falco-${FALCO_VERSION}-aarch64.rpm -r rpm

/source/falco/scripts/publish-deb -f /build/release/falco-${FALCO_VERSION}-x86_64.deb -f /build/release/falco-${FALCO_VERSION}-aarch64.deb -r deb-dev

(notice that passing both packages in a single call is needed!)
Can you update your PR accordingly?
Thanks!

odidev · 2022-05-17T07:44:04Z

Mmh aren't we actually testing it? https://github.com/falcosecurity/falco/pull/1997/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R14

Ah ok updated.

Oh i see thanks! Yeah renaming the job should do the trick; i think you can proceed with that!

I have changed the name of the job and validated configuration file using CircleCI command line tool as well.
Note: I had to change name of all jobs as / was present in the name of jobs which generates error in workflow 2.1 as CircleCI that it is not able to find orb of the name same as letters before the /.

(notice that passing both packages in a single call is needed!)
Can you update your PR accordingly?
Thanks!

I have updated it accordingly.

FedeDP · 2022-05-17T08:45:55Z

Wow thank you! This PR should be ready once my #1990 is merged!
Thank you for your really hard work!!

odidev · 2022-05-24T06:04:04Z

Since this PR depends on #1990 , by when can we expect it to get merged?

FedeDP · 2022-05-24T08:38:34Z

Hi @odidev !
Unfortunately, it was just decided to skip arm64 for the 0.32 release; instead, we are targeting the 0.33; but i've got a certain degree of confidence that we will be able to make a 0.32.1 patch release for it, as it has a huge value for the community.
Unfortunately, we are very near the 0.32 release and testing this will take much time.

/milestone 0.33.0

leogr · 2022-05-24T14:33:46Z

/milestone 0.33.0

leogr · 2022-06-08T17:14:58Z

Quick update: we're trying to test the new falcosecurity/falco-builder with this PR. So, sorry if we're spamming you 😅 We hope are close to a fix.

Signed-off-by: Leonardo Grasso <[email protected]>

poiana · 2022-06-08T17:23:53Z

LGTM label has been added.

Git tree hash: d70248bc5e26c4eb8d596668f04f3be003429cef

jasondellaluce

/approve

poiana · 2022-06-08T17:24:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, odidev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.circleci/OWNERS~~ [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

leogr · 2022-06-09T06:15:17Z

Closing and reopening to trigger the CI
/close

poiana · 2022-06-09T06:15:20Z

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr · 2022-06-09T06:15:24Z

/reopen

poiana · 2022-06-09T06:15:27Z

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

See falcosecurity/falco#1997 Signed-off-by: Leonardo Grasso <[email protected]>

leogr · 2022-06-09T06:33:00Z

Closing and reopening to update CI required checks
/close

poiana · 2022-06-09T06:33:03Z

@leogr: Closed this PR.

In response to this:

Closing and reopening to update CI required checks
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr · 2022-06-09T06:33:07Z

/reopen

poiana · 2022-06-09T06:33:11Z

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

poiana added release-note-none kind/feature dco-signoff: yes area/build labels May 10, 2022

poiana requested review from jonahjon and leogr May 10, 2022 13:47

poiana added the size/M label May 10, 2022

odidev mentioned this pull request May 10, 2022

Circle CI: Enable testing for ARM64 platform #1891

Closed

FedeDP reviewed May 10, 2022

View reviewed changes

FedeDP mentioned this pull request May 10, 2022

Cut 0.32.0 Release #1993

Closed

53 tasks

odidev force-pushed the arm-build branch 2 times, most recently from 035947b to 42f08d4 Compare May 11, 2022 09:23

odidev force-pushed the arm-build branch from 42f08d4 to a8ba6c9 Compare May 16, 2022 12:13

poiana added size/L and removed size/M labels May 16, 2022

odidev force-pushed the arm-build branch from a8ba6c9 to 26c8807 Compare May 17, 2022 04:56

leogr force-pushed the arm-build branch from 2a212c1 to 5a075eb Compare June 8, 2022 16:35

fix(.circleci): correct command for build-arm64

2aed7ff

Signed-off-by: Leonardo Grasso <[email protected]>

leogr force-pushed the arm-build branch from 5a075eb to 2aed7ff Compare June 8, 2022 17:16

leogr approved these changes Jun 8, 2022

View reviewed changes

poiana assigned leogr Jun 8, 2022

poiana added the lgtm label Jun 8, 2022

jasondellaluce approved these changes Jun 8, 2022

View reviewed changes

poiana assigned jasondellaluce Jun 8, 2022

poiana added the approved label Jun 8, 2022

poiana closed this Jun 9, 2022

poiana reopened this Jun 9, 2022

leogr added a commit to falcosecurity/test-infra that referenced this pull request Jun 9, 2022

fix(config): update required_status_checks for Falco

61870f2

See falcosecurity/falco#1997 Signed-off-by: Leonardo Grasso <[email protected]>

leogr mentioned this pull request Jun 9, 2022

fix(config): update required_status_checks for Falco falcosecurity/test-infra#719

Merged

poiana pushed a commit to falcosecurity/test-infra that referenced this pull request Jun 9, 2022

fix(config): update required_status_checks for Falco

cfda0b5

See falcosecurity/falco#1997 Signed-off-by: Leonardo Grasso <[email protected]>

poiana closed this Jun 9, 2022

poiana reopened this Jun 9, 2022

poiana merged commit aad70f3 into falcosecurity:master Jun 9, 2022

jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Circle CI build job for ARM64 #1997

Circle CI build job for ARM64 #1997

odidev commented May 10, 2022 •

edited

Loading

poiana commented May 10, 2022

FedeDP May 10, 2022 •

edited

Loading

odidev May 12, 2022

FedeDP May 10, 2022

odidev May 12, 2022

FedeDP commented May 10, 2022 •

edited

Loading

FedeDP commented May 10, 2022

FedeDP commented May 11, 2022 •

edited

Loading

FedeDP commented May 12, 2022

odidev commented May 12, 2022

FedeDP commented May 12, 2022

FedeDP commented May 13, 2022

odidev commented May 17, 2022

FedeDP commented May 17, 2022

odidev commented May 24, 2022

FedeDP commented May 24, 2022 •

edited

Loading

leogr commented May 24, 2022

leogr commented Jun 8, 2022

poiana commented Jun 8, 2022

jasondellaluce left a comment

poiana commented Jun 8, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

Circle CI build job for ARM64 #1997

Circle CI build job for ARM64 #1997

Conversation

odidev commented May 10, 2022 • edited Loading

poiana commented May 10, 2022

FedeDP May 10, 2022 • edited Loading

Choose a reason for hiding this comment

odidev May 12, 2022

Choose a reason for hiding this comment

FedeDP May 10, 2022

Choose a reason for hiding this comment

odidev May 12, 2022

Choose a reason for hiding this comment

FedeDP commented May 10, 2022 • edited Loading

Build and test workflow

Release workflow

FedeDP commented May 10, 2022

FedeDP commented May 11, 2022 • edited Loading

FedeDP commented May 12, 2022

odidev commented May 12, 2022

FedeDP commented May 12, 2022

FedeDP commented May 13, 2022

odidev commented May 17, 2022

FedeDP commented May 17, 2022

odidev commented May 24, 2022

FedeDP commented May 24, 2022 • edited Loading

leogr commented May 24, 2022

leogr commented Jun 8, 2022

poiana commented Jun 8, 2022

jasondellaluce left a comment

Choose a reason for hiding this comment

poiana commented Jun 8, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

leogr commented Jun 9, 2022

poiana commented Jun 9, 2022

odidev commented May 10, 2022 •

edited

Loading

FedeDP May 10, 2022 •

edited

Loading

FedeDP commented May 10, 2022 •

edited

Loading

FedeDP commented May 11, 2022 •

edited

Loading

FedeDP commented May 24, 2022 •

edited

Loading