-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved detection for connections to miner pools #2011
Conversation
Signed-off-by: beryxz <[email protected]>
Welcome @beryxz! It looks like this is your first PR to falcosecurity/falco 🎉 |
/milestone 0.32.0 |
Closing and reopening to disenchant |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
LGTM
LGTM label has been added. Git tree hash: 62fd54b18a94314b892a1fa19a8a2fed354a4382
|
/cc @Kaizhe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: beryxz, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: beryxz [email protected]
What type of PR is this?
/kind feature
/kind rule-update
Any specific area of the project related to this PR?
/area rules
/area proposals
What this PR does / why we need it:
While testing I noticed that the
Detect outbound connections to common miner pool ports
rule didn't work against "xmrig". The reason is that thesendto
syscall is only used with the DNS server as shown:After retrieving the IP of the pool,
write
is used in place ofsend
, I don't know exactly why, but they are equivalent after all.As
getsockopt
,read
, andwrite
are not supported by Falco, the only other option seems to be theconnect
syscall. Withevt.type = connect and evt.dir = <
the rule can also detect xmrig thorugh the samefd.sip.name
field.Which issue(s) this PR fixes:
Detect outbound connections to common miner pool ports
rules doesn't detect xmrig connecting to nanopool.Special notes for your reviewer:
If needed I can provide further details.
Does this PR introduce a user-facing change?: