update(build): Switch from RSA/SHA1 to RSA/SHA256 signature in the RPM package

[vjjmiras]

Signed-off-by: Vicente J. Jiménez Miras [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(build): Switch from RSA/SHA1 to RSA/SHA256 signature in the RPM package

[poiana]

Welcome @vjjmiras! It looks like this is your first PR to falcosecurity/falco 🎉

[vjjmiras]

There are 3 options to add this flag:

1. The one used in this commit, adding a macro to pass --digest-algo sha256 to the gpg binary, in the ~/.rpmmacros file.
2. In the Expect script, adding "--digest-algo sha256" between the 'rpm sign --addsign' and the '{*}$argv', like 'rpm sign --addsign --digest-algo sha256 {*}$argv'
3. In the .circle/config.yml file, as a parameter to the Expect script, like ./sign --digest-algo sha256 *rpm

I tried the 3 options locally inside a falcosecurit/falco-builder based container, and they all gave me the same results:

# rpm --qf '%{SIGPGP:pgpsig}\n' -q -p test.rpm
warning: test.rpm: Header V4 RSA/SHA256 Signature, key ID a2559cf9: NOKEY
RSA/SHA256, Wed Jun 8 07:59:54 2022, Key ID f27799c2a2559cf9

The warning responds to the lack of the public key imported to the RPM database.

[jasondellaluce]

/milestone 0.33.0

[FedeDP]

LGTM :) thank you very much!

[poiana]

LGTM label has been added.

Git tree hash: c878d627589a24fbbd4a700a6592444f7cfc58db

[poiana]

LGTM label has been added.

Git tree hash: c878d627589a24fbbd4a700a6592444f7cfc58db

[jasondellaluce]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, vjjmiras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• .circleci/OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment