Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(userspace/falco): make webserver threadiness configurable #2090

Merged
merged 4 commits into from
Aug 26, 2022
Merged

update(userspace/falco): make webserver threadiness configurable #2090

merged 4 commits into from
Aug 26, 2022

Conversation

jasondellaluce
Copy link
Contributor

@jasondellaluce jasondellaluce commented Jun 23, 2022 •
edited
Loading

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This improves the webserver by making the thread pool size configurable (by default equal to the number of online cores).

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(userspace/falco): make webserver threadiness configurable

@jasondellaluce jasondellaluce mentioned this pull request Jun 23, 2022
Closed
15 tasks
@poiana poiana requested review from FedeDP and mstemm June 23, 2022 09:19
@jasondellaluce
Copy link
Contributor Author

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 23, 2022
@jasondellaluce jasondellaluce force-pushed the refactor/optimize-webserver branch from 310cb41 to ba3fc0b Compare June 23, 2022 11:14
@jasondellaluce jasondellaluce mentioned this pull request Jun 23, 2022
Closed
15 tasks
@jasondellaluce jasondellaluce force-pushed the refactor/optimize-webserver branch from ba3fc0b to 91df831 Compare June 23, 2022 16:54
@jasondellaluce jasondellaluce changed the title update(userspace/falco): leverage zlib in webserver and make threadiness configurable update(userspace/falco): make webserver threadiness configurable Jul 12, 2022
@jasondellaluce
Copy link
Contributor Author

Splitted this PR so that zlib support is now contributed in #2125

leogr
leogr previously approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Aug 25, 2022
@poiana
Copy link
Contributor

poiana commented Aug 25, 2022

LGTM label has been added.

Git tree hash: 84ce727d8295aa21a9c2475b3e98c6c495828f36

FedeDP
FedeDP previously approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jasondellaluce
Copy link
Contributor Author

Closing and reopening to trigger the CI

/close

@poiana poiana closed this Aug 25, 2022
@poiana
Copy link
Contributor

poiana commented Aug 25, 2022

@jasondellaluce: Closed this PR.

In response to this:

Closing and reopening to trigger the CI

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor Author

/reopen

@poiana
Copy link
Contributor

poiana commented Aug 25, 2022

@jasondellaluce: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Aug 25, 2022
@jasondellaluce jasondellaluce dismissed stale reviews from FedeDP and leogr via 7997a88 August 26, 2022 07:21
@jasondellaluce jasondellaluce force-pushed the refactor/optimize-webserver branch from 90eb9dc to 7997a88 Compare August 26, 2022 07:21
@poiana poiana removed the lgtm label Aug 26, 2022
@poiana poiana requested review from FedeDP and leogr August 26, 2022 07:21
FedeDP
FedeDP approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Aug 26, 2022
@poiana
Copy link
Contributor

poiana commented Aug 26, 2022

LGTM label has been added.

Git tree hash: 86d4d6dd21f4830e0f7d618082b48bf89347ea29

@poiana
Copy link
Contributor

poiana commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3839fdc into master Aug 26, 2022
@poiana poiana deleted the refactor/optimize-webserver branch August 26, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@leogr leogr leogr approved these changes

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/engine dco-signoff: yes kind/feature lgtm release-note size/M
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jasondellaluce @poiana @leogr @FedeDP