Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test/utils): remove unused script #2157

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

Andreagit97
Copy link
Member

Signed-off-by: Andrea Terzolo [email protected]

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

This PR removes an unused script in test/utils/run_sysdig.sh

Which issue(s) this PR fixes:

Special notes for your reviewer:

NONE

@leogr
Copy link
Member

leogr commented Aug 5, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Aug 5, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 👍

Thank you!

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 5, 2022

LGTM label has been added.

Git tree hash: fc54620f5fc4f07b2c00004a4498b3c1cbf0f40b

@poiana
Copy link
Contributor

poiana commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 5, 2022
@poiana poiana merged commit ff247f9 into falcosecurity:master Aug 5, 2022
@Andreagit97 Andreagit97 deleted the remove_unused_script branch October 15, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants