-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: configure syscall buffer dimension from Falco #2214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment; otherwise this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
I've just left some suggestions (nitpicking 😸)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 5c95ce7172deeca86625ee937bbb3f6d92d7354a
|
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Leonardo Grasso <[email protected]> Co-authored-by: Melissa Kilby <[email protected]>
improve also some logs for `m_syscall_buf_size_preset` configuration errors Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Jason Dellaluce <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
7e8bf42
to
69031bf
Compare
Rebased on actual master just to have this fix #2215 |
/milestone 0.33.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
LGTM label has been added. Git tree hash: 450a6f8a38ed518bcd8fc9921aa2ee755470b0e0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
As discussed in various places (#2164 (comment), #2164 (comment), #2208) this PR adds the possibility to change the syscall buffer dimension through the Falco configuration file.
The approach used is the one described here #2208 (comment). Users will have an array of indexes that map to precise buffer dimensions in bytes. You can find more information in the
falco.yaml
file, but just for simplicity I report them here:I added also a new command line option
--page-size
to let the user easily obtain the page size of their systemIf you have any suggestions I'm all ears :)
Which issue(s) this PR fixes:
Fixes #2208
Special notes for your reviewer:
Does this PR introduce a user-facing change?: