Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(cmdline): add development support for modern BPF probe #2221

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR adds the possibility to start Falco with the modern BPF probe. This cmd line option MUST be used only during development, it is not production ready! For this reason, it is compiled out unless we use the -DBUILD_FALCO_MODERN_BPF=ON CMake option

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(cmdline): add development support for modern BPF probe

@Andreagit97 Andreagit97 changed the title new(cmdline): add development support for modern BPF probe [WIP] new(cmdline): add development support for modern BPF probe Sep 24, 2022
@poiana poiana requested review from Kaizhe and leogr September 24, 2022 17:15
@FedeDP
Copy link
Contributor

FedeDP commented Sep 24, 2022

Looking forward to this!:heart_eyes:

@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Sep 27, 2022
@Andreagit97 Andreagit97 changed the title [WIP] new(cmdline): add development support for modern BPF probe new(cmdline): add development support for modern BPF probe Sep 28, 2022
@poiana
Copy link
Contributor

poiana commented Sep 28, 2022

LGTM label has been added.

Git tree hash: ed38de7e999ff0d99166d2a45c91bbcaafbe6fcd

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 545b58e into falcosecurity:master Sep 28, 2022
@Andreagit97 Andreagit97 deleted the support_modern_bpf branch October 15, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants